MVPXML Work Item Rss Feed

Closed Issue: ExsltDateTime [4970]

olegt — Thu, 16 May 2013 07:42:24 GMT

stefano.zanotti@summer.it

public ExsltDateTime("2005-12-08T00:00:00")

BUG
in

int hours = Int32.Parse(zoneStr.Substring
(0,3));

/// <summary>
/// Initialize the DateTimeTZ structure with the
date, time and timezone in the string.
/// </summary>
/// <param name="inS">An ISO8601 string</param>
public ExsltDateTime(string inS)

ExsltDateTime("2005-08-12T00:00:00")

BUG

int minutes = Int32.Parse(zoneStr.Substring
(4,2));

Closed Issue: Exslt set:distinct function does not work with MONO [4975]

olegt — Thu, 16 May 2013 07:42:24 GMT

I checked the attached xslt with nxslt.exe and the
following error occured:

System.Xml.Xsl.XsltException: Custom function reported
an error. --->
System.Reflection.TargetInvocationException: Exception
has been thrown by the target of an invocation. --->
System.ArgumentNullException: Argument cannot be null.
Parameter name: type
in <0x0006e> System.Activator:CheckType (System.Type type)
in <0x00039> System.Activator:CreateInstance
(System.Type type, BindingFlags bindingAttr,
System.Reflection.Binder binder, System.Object[] args,
System.Globalization.CultureInfo culture,
System.Object[] activationAttributes)
in <0x00029> System.Activator:CreateInstance
(System.Type type, BindingFlags bindingAttr,
System.Reflection.Binder binder, System.Object[] args,
System.Globalization.CultureInfo culture)
in <0x0006d>
Mvp.Xml.Exslt.ExsltCommon:ExsltNodeListToXPathNodeIterator
(Mvp.Xml.Exslt.ExsltNodeList list)
in <0x000cd> Mvp.Xml.Exslt.ExsltSets:distinct
(System.Xml.XPath.XPathNodeIterator nodeset)
in <0x00000> <unknown method>
in (wrapper managed-to-native)
System.Reflection.MonoMethod:InternalInvoke
(object,object[])
in <0x0008d> System.Reflection.MonoMethod:Invoke
(System.Object obj, BindingFlags invokeAttr,
System.Reflection.Binder binder, System.Object[]
parameters, System.Globalization.CultureInfo
culture)--- End of inner exception stack trace ---

in <0x0010e> System.Reflection.MonoMethod:Invoke
(System.Object obj, BindingFlags invokeAttr,
System.Reflection.Binder binder, System.Object[]
parameters, System.Globalization.CultureInfo culture)
in <0x0001a> System.Reflection.MethodBase:Invoke
(System.Object obj, System.Object[] parameters)
in <0x00243> Mono.Xml.Xsl.XsltExtensionFunction:Invoke
(Mono.Xml.Xsl.XsltCompiledContext xsltContext,
System.Object[] args, System.Xml.XPath.XPathNavigator
docContext)--- End of inner exception stack trace ---

in <0x00332> Mono.Xml.Xsl.XsltExtensionFunction:Invoke
(Mono.Xml.Xsl.XsltCompiledContext xsltContext,
System.Object[] args, System.Xml.XPath.XPathNavigator
docContext)
in <0x00032> Mono.Xml.Xsl.XPFuncImpl:Invoke
(System.Xml.Xsl.XsltContext xsltContext,
System.Object[] args, System.Xml.XPath.XPathNavigator
docContext)
in <0x00236> System.Xml.XPath.ExprFunctionCall:Evaluate
(System.Xml.XPath.BaseIterator iter)
in <0x00060>
System.Xml.XPath.Expression:EvaluateNodeSet
(System.Xml.XPath.BaseIterator iter)
in <0x00014>
System.Xml.XPath.CompiledExpression:EvaluateNodeSet
(System.Xml.XPath.BaseIterator iter)
in <0x00067> System.Xml.XPath.XPathNavigator:Select
(System.Xml.XPath.XPathExpression expr,
System.Xml.XmlNamespaceManager ctx)
in <0x00050> Mono.Xml.Xsl.XslTransformProcessor:Select
(System.Xml.XPath.XPathExpression expr)
in <0x00025>
Mono.Xml.Xsl.Operations.XslForEach:Evaluate
(Mono.Xml.Xsl.XslTransformProcessor p)
in <0x00078>
Mono.Xml.Xsl.Operations.XslTemplateContent:Evaluate
(Mono.Xml.Xsl.XslTransformProcessor p)
in <0x0017a>
Mono.Xml.Xsl.Operations.XslLiteralElement:Evaluate
(Mono.Xml.Xsl.XslTransformProcessor p)
in <0x00078>
Mono.Xml.Xsl.Operations.XslTemplateContent:Evaluate
(Mono.Xml.Xsl.XslTransformProcessor p)
in <0x00189> Mono.Xml.Xsl.XslTemplate:Evaluate
(Mono.Xml.Xsl.XslTransformProcessor p,
System.Collections.Hashtable withParams)
in <0x00064>
Mono.Xml.Xsl.XslTransformProcessor:ApplyTemplates
(System.Xml.XPath.XPathNodeIterator nodes,
System.Xml.XmlQualifiedName mode,
System.Collections.ArrayList withParams)
in <0x00496> Mono.Xml.Xsl.XslTransformProcessor:Process
(System.Xml.XPath.XPathNavigator root,
Mono.Xml.Xsl.Outputter outputtter,
System.Xml.Xsl.XsltArgumentList args,
System.Xml.XmlResolver resolver)
in <0x0008b> System.Xml.Xsl.XslTransform:Transform
(System.Xml.XPath.XPathNavigator input,
System.Xml.Xsl.XsltArgumentList args,
System.IO.TextWriter output, System.Xml.XmlResolver
resolver)
in <0x00037> System.Xml.Xsl.XslTransform:Transform
(IXPathNavigable input, System.Xml.Xsl.XsltArgumentList
args, System.IO.TextWriter output)
in <0x0008a> Mvp.Xml.Exslt.ExsltTransform:Transform
(IXPathNavigable ixn, System.Xml.Xsl.XsltArgumentList
arglist, System.IO.TextWriter writer)
in <0x03711> NXslt.NXslt:Process ()
Tested with Mono JIT compiler version 1.1.13.2 and Linux

Closed Issue: href="x.xsl" type="text/xsl" bug [6053]

olegt — Thu, 16 May 2013 07:42:23 GMT

I noticed that nxslt (both 1 and 2) succeds when using an xml-stylesheet
PI like the following (obviously)

<?xml-stylesheet type="text/xsl" href="x.xsl"?>

but fails with the following

<?xml-stylesheet href="x.xsl" type="text/xsl"?>

i.e. when the 'href' PseudoAtt precedes the 'type' PseudoAtt.

Thanks for an otherwise great app :-)

-- David Håsäther

Created Issue: date:date() returning time [33579]

jasonma — Mon, 17 Dec 2012 22:50:56 GMT

Calling date:date() returns a date value with a time portion (i.e. "2012-12-12:07:00")

I discovered this when doing this call:
date:year(normalize-space(date:add(normalize-space(date:date()),normalize-space('-P3M5D'))))

The date:year(string) call could not parse out the time portion and would return NaN.

I think this can be solved by overriding the HasTimeZone() method in DateTz to return false.

Please verify.

Commented Issue: MvpXslTransform.Load doesn't close xml reader [14361]

Kstubs — Tue, 20 Dec 2011 21:30:02 GMT

Method MvpXslTransform.Load(string stylesheetUri, XsltSettings settings, XmlResolver stylesheetResolver) opens XmlReader for given stylesheetUri and doesn't close it after use. So stylesheet file got locked. I think it's necessary to add using statement. Like this:

public void Load(string stylesheetUri, XsltSettings settings, XmlResolver stylesheetResolver)
{
using( XmlReader reader = XmlReader.Create(stylesheetUri)
this.LoadStylesheetFromReader(reader, settings, stylesheetResolver);
}
Comments: ** Comment from web user: Kstubs **

Has this been resolved?

Created Issue: xmllab.net site not working [29993]

schalkvanwyk — Wed, 19 Jan 2011 10:30:32 GMT

Hi
I tried to read more about the project on the referenced site, but it seems like http://www.xmllab.net site has been broken

Commented Issue: XmlSerializerCache is not thread safe (fix included) [26717]

taliesins — Wed, 07 Apr 2010 14:04:44 GMT

public System.Xml.Serialization.XmlSerializer GetSerializer(Type type
, XmlAttributeOverrides overrides
, Type[] types
, XmlRootAttribute root
, String defaultNamespace)
{
string key = CacheKeyFactory.MakeKey(type
, overrides
, types
, root
, defaultNamespace);

System.Xml.Serialization.XmlSerializer serializer = null;

var isCacheHit = false;

if (!Serializers.TryGetValue(key, out serializer))
{
lock (SyncRoot)
{
if (!Serializers.TryGetValue(key, out serializer))
{
serializer = new System.Xml.Serialization.XmlSerializer(type
, overrides
, types
, root
, defaultNamespace);

Serializers.Add(key, serializer);

if (null != NewSerializer)
{
NewSerializer(type
, overrides
, types
, root
, defaultNamespace);
}
}
else
{
isCacheHit = true;
}
}
}
else
{
isCacheHit = true;
}

if (isCacheHit && CacheHit != null)
{
// Tell the listeners that we already
// had a serializer that matched the attributes

CacheHit(type
, overrides
, types
, root
, defaultNamespace);
}

System.Diagnostics.Debug.Assert(null != serializer);
return serializer;
}
Comments: ** Comment from web user: taliesins **

This same approach could be used to fix GetCompiledExpression thread safety problem.

Created Issue: XmlSerializerCache is not thread safe (fix included) [26717]

taliesins — Wed, 07 Apr 2010 14:02:43 GMT

Commented Issue: File included with XInclude is locked after reading [26169]

williware — Thu, 01 Apr 2010 02:25:08 GMT

After reading included XML files with XIncludeReader, the included XML file is locked on filesystem level.

This can be fixed by modifing XIncludeReader.CreateAcquiredInfoset(Uri includeLocation) to:

/// <summary>
/// Creates acquired infoset.
/// </summary>
private string CreateAcquiredInfoset(Uri includeLocation)
{
if (_cache == null)
_cache = new Dictionary<string, WeakReference>();
WeakReference wr;
if (_cache.TryGetValue(includeLocation.AbsoluteUri, out wr) && wr.IsAlive)
{
return (string)wr.Target;
}
else
{
//Not cached or GCollected
WebResponse wRes;
string content = null;
using (Stream stream = GetResource(includeLocation.AbsoluteUri,
_reader.GetAttribute(_keywords.Accept),
_reader.GetAttribute(_keywords.AcceptLanguage), out wRes))
{
using (XIncludingReader xir = new XIncludingReader(wRes.ResponseUri.AbsoluteUri, stream, _nameTable))
{
xir.WhitespaceHandling = _whiteSpaceHandling;
using (StringWriter sw = new StringWriter())
{
using (XmlTextWriter w = new XmlTextWriter(sw))
{
try
{
while (xir.Read())
w.WriteNode(xir, false);
}
finally
{
if (xir != null)
xir.Close();
if (w != null)
w.Close();
}
content = sw.ToString();
}
}
}
}
if (content != null)
{
lock (_cache)
{
if (!_cache.ContainsKey(includeLocation.AbsoluteUri))
_cache.Add(includeLocation.AbsoluteUri, new WeakReference(content));
}
}
return content;
}
}
Comments: ** Comment from web user: williware **

I was utilizing my own resolver. The call mentioned above (CreateAcquiredInfoset) is never executed. My resolver returns a stream. The stream was used to create the XmlBaseAwareXmlReader. The XmlBaseAwareXmlReader gets closed when popped, but the underlying stream is not by default. I added the line 'settings.CloseInput = true;' to all of the CreateReaderSettings functions. Code follows. I believe this is the correct default behavior because the stream was retrieved via an external resolver's GetEntity and this code would be the only place it can be closed.

private static XmlReaderSettings CreateReaderSettings() {
XmlReaderSettings settings = new XmlReaderSettings();
settings.ProhibitDtd = false;
settings.CloseInput = true;
return settings;
}

private static XmlReaderSettings CreateReaderSettings(XmlResolver resolver)
{
XmlReaderSettings settings = CreateReaderSettings();
settings.XmlResolver = resolver;
settings.CloseInput = true;
return settings;
}

private static XmlReaderSettings CreateReaderSettings(XmlNameTable nt)
{
XmlReaderSettings settings = CreateReaderSettings();
settings.NameTable = nt;
settings.CloseInput = true;
return settings;
}

Commented Issue: File included with XInclude is locked after reading [26169]

williware — Mon, 29 Mar 2010 21:24:06 GMT

I am having the same issue. The Filestream returned by my resolver is left open.

Created Issue: File included with XInclude is locked after reading [26169]

NielsVr — Wed, 10 Feb 2010 09:43:02 GMT

Created Issue: XIncludingReader drops top-level attributes with Saxon.NET [25579]

serge_sh — Tue, 08 Dec 2009 06:27:11 GMT

XIncludingReader seems to drop the top-level attributes of the included XML file when used with the Saxon.NET engine.
The bug appears to be with Oleg's changes to MoveToAttribute(int i), where he forgets to reset the state back to Default as follows:
if (i >= _reader.AttributeCount || i == _realXmlBaseIndex)
{
_state = XIncludingReaderState.ExposingXmlBaseAttr;
}
else
{
_state = XIncludingReaderState.Default;
_reader.MoveToAttribute(i);
}

Also, we may want to actually set the state to ExposingXmlLangAttr inside the first statement like this:
if (i > _reader.AttributeCount && _differentLang)
_state = XIncludingReaderState.ExposingXmlLangAttr;

Created Issue: XPathDocumentWriter static constructor doesn't properly revert CAS assertion [25131]

element533 — Wed, 28 Oct 2009 21:09:21 GMT

Not sure if this has already been noted or is fixed yet, but I was just digging around in reflector and found a CAS flaw:

static XPathDocumentWriter()
{
ReflectionPermission perm = new ReflectionPermission(PermissionState.Unrestricted);
perm.Flags = ReflectionPermissionFlag.MemberAccess;
try
{
perm.Assert();
Type t = typeof(XPathDocument);
defaultConstructor = t.GetConstructor(BindingFlags.NonPublic | BindingFlags.Instance, null, Type.EmptyTypes, new ParameterModifier[0]);
loadWriterMethod = t.GetMethod("LoadFromWriter", BindingFlags.NonPublic | BindingFlags.Instance);
}
finally
{
CodeAccessPermission.RevertAssert();
}
}

CAS reversions should be done in catch-all handlers to prevent upstream exception filters from having the chance to run under elevated CAS permissions. The above code should be rewritten as:

static XPathDocumentWriter()
{
ReflectionPermission perm = new ReflectionPermission(PermissionState.Unrestricted);
perm.Flags = ReflectionPermissionFlag.MemberAccess;
try
{
perm.Assert();
Type t = typeof(XPathDocument);
defaultConstructor = t.GetConstructor(BindingFlags.NonPublic | BindingFlags.Instance, null, Type.EmptyTypes, new ParameterModifier[0]);
loadWriterMethod = t.GetMethod("LoadFromWriter", BindingFlags.NonPublic | BindingFlags.Instance);
CodeAccessPermission.RevertAssert();
}
catch
{
CodeAccessPermission.RevertAssert();
throw;
}
}

It's possible that other areas in the library need to be similarly updated. If you need more information, there is a reasonable body of knowledge on the Internet regarding this aspect of CAS.

BTW, Mvp.Xml is a really cool library, and I love using it!

Created Issue: GetCompiledExpression is not thread-safe

dkoning — Mon, 27 Apr 2009 14:57:49 GMT

We were using a previous version of mvp and got the error:
[IndexOutOfRangeException: Index was outside the bounds of the array.]
System.Collections.Generic.Dictionary`2.Insert(TKey key, TValue value, Boolean add) +7460198
System.Collections.Generic.Dictionary`2.set_Item(TKey key, TValue value) +11
Mvp.Xml.Common.XPath.XPathCache.GetCompiledExpression(String expression, XPathNavigator source) +68
Mvp.Xml.Common.XPath.XPathCache.SelectNodes(String expression, XmlNode source) +25

I saw this has been changed already: now a Hashtable is being used as cache. But still, this is not completely fixed, because the Hashtable is also not thread-safe, so you should use locking. Otherwise it might throw errors if you are adding more than one element at the same time to the cache.

My suggestion for the code would be:

private static readonly Dictionary<string, XPathExpression> Cache = new Dictionary<string, XPathExpression>();

/// <summary>
/// Retrieves a cached compiled expression, or a newly compiled one.
/// </summary>
private static XPathExpression GetCompiledExpression(string expression, XPathNavigator source)
{
if (!Cache.ContainsKey(expression))
{
XPathExpression expr = source.Compile(expression);
lock (Cache)
if (!Cache.ContainsKey(expression)) // it might have been added in the meanwhile
Cache.Add(expression, expr);
}
return Cache[expression].Clone();
}

Created Issue: XIncludingReader.WhitespaceHandling doesn't seem to do anything

frinetik — Tue, 04 Nov 2008 21:09:19 GMT

Maybe it's just me, but it doesn't appear that XIncludingReader.WhitespaceHandling actually does anything. No matter what I set it to, I always end up with whitespace nodes.

I implemented a workaround in the code that may be useful. In XIncludingReader.cs, Read(), before the switch (_reader.NodeType) I added:

if (_reader.NodeType == XmlNodeType.Whitespace && _whiteSpaceHandling != WhitespaceHandling.All)
_reader.Read();

This makes everything work as I'd expect for WhitespaceHandling.None and WhitespaceHandling.All (admittedly, WhitespaceHandling.Significant isn't handled properly by this).

Is there somewhere else that XIncludingReader.WhitespaceHandling is supposed to work?

Commented Issue: MvpXslTransform.Load doesn't close xml reader

earthware — Thu, 23 Oct 2008 20:19:43 GMT

yup I find this a real pain when doing any xlslt transform during development as it keeps the file locked until iis is restarted

Commented Issue: xinclude / encoding problem

psohm — Thu, 04 Sep 2008 15:31:16 GMT

hello
i've a problem with encoding and i can't resolve it.
I have a project which use the .net 2 xml api and everything work fine.
but if i have a file which contains strange characters (i don't put an example, otherwise codeplex refuse my post), xinclude don't word (but .net work)

the error message is :
..., valeur hexadécimale 0x0B, est un caractère non valide. Ligne 3, position 31."

i have made an example project which reproduce the bug
do you know how to solve that problem ?
although i admit i'm a bit lost, i think it's a encoding problem

thanks
Comments: ** Comment from web user: psohm **

the xml example file is :

<?xml version="1.0" encoding="utf-8"?>
<Magasin xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
<Client Nom="KKK QK Q QKQKK Q QK" />
</Magasin>

Created Issue: xinclude / encoding problem

psohm — Thu, 04 Sep 2008 15:28:47 GMT

Commented Issue: Cannot get XpathCache to replace variables.

dcazzulino — Tue, 08 Jul 2008 05:18:35 GMT

I cannot get XpathCache to replace dynamic xpath variables in my xpath expression. I know the expression evaluates if I hardcode some test values.

This works:
string MenuDepthXpathStr = "/descendant-or-self::ul[count(ancestor-or-self::ul) >= $depth]";
string Depth = "1";

XPathNodeIterator TempList = XPathCache.Select(MenuDepthXpathStr, MenuDocXml, new XmlNamespaceManager(MenuDocXml.NameTable), new XPathVariable("depth", Depth));

However this doesnt:
string MenuDepthXpathStr = "/descendant-or-self::ul[count(ancestor-or-self::ul) >= $depth $highlighted]";
string Depth = "1";
string Highlighted = (SomeBoolVal? "and contains(@class, 'expanded')" : "");

XPathNodeIterator TempList = XPathCache.Select(MenuDepthXpathStr, MenuDocXml, new XmlNamespaceManager(MenuDocXml.NameTable), new XPathVariable("depth", Depth), new XPathVariable("highlighted", Highlighted));

It seems as though my variable cannot contain xpath it can only be values. Why is this? Is there any way to dynamically generate the xpath itself and not just insert values?
Comments: ** Comment from web user: dcazzulino **

That's just now how xslt variables work. We're just making it easier to use a feature that's provided by the System.Xml.Xsl namespace. We can't make changes, and I don't anticipate MS doing them either.

Again, if you're invoking Sprocs, you cannot do that. I'm afraid this is internally (.NET) the same.

Closed Issue: Cannot get XpathCache to replace variables.

dcazzulino — Tue, 08 Jul 2008 05:15:26 GMT